Specify ES configuration for OSes with systemd#38
Open
tobywf wants to merge 2 commits intosaltstack-formulas:masterfrom
tobywf:master
Open
Specify ES configuration for OSes with systemd#38tobywf wants to merge 2 commits intosaltstack-formulas:masterfrom tobywf:master
tobywf wants to merge 2 commits intosaltstack-formulas:masterfrom
tobywf:master
Conversation
kartnico
approved these changes
Jul 11, 2017
kartnico
left a comment
kartnico
left a comment
There was a problem hiding this comment.
I have the same problem in Travis CI kitchen for my PR.
Regards,
Nicolas
Contributor
|
@tobywf , could you add some pillar.example configuration for this adddition? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On systems with systemd, system limits must be specified via a systemd service file. This PR adds that. The service file is only created if
elasticsearch.systemdis specified.I tried to use
file.serializewith an ini formatter, but that doesn't maintain the case of the keys, and systemd is case sensitive. So I used a jinja template.Let me know anything needs fixing.