Skip to content

Conversation

@Zuke97
Copy link
Contributor

@Zuke97 Zuke97 commented Nov 14, 2025

Description

For the upcoming holidays, created a role for Wishlist to have collaborative wishlists for your friends and family. It has it's own authentication with whoever logging in after first install being able to register themselves as the admin. It also can allow lists to be public, or create invitation links to specific lists.

Docs PR: saltyorg/docs#378

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration. You can use the checkboxes below or delete them as you wish.

  • Installed on local machine
  • Verified configurations and data persists through container deletion and recreation
  • Sent invite link to another outside of local network and confirmed access
  • Verified javascript bookmark functionality (instructions on github) on local network

@Zuke97 Zuke97 mentioned this pull request Nov 14, 2025
4 tasks
@Zuke97 Zuke97 marked this pull request as ready for review November 14, 2025 03:06
@owine
Copy link
Collaborator

owine commented Nov 14, 2025

Thanks for the PR. Looking at upstream, they support Header Authentication which would slot in perfectly with our SSO (assuming there is a unique endpoint for public links that could be whitelisted). I'd say that's the preferred method rather than double auth.

@Zuke97
Copy link
Contributor Author

Zuke97 commented Nov 14, 2025

I think that makes sense for anonymous public lists. I'll do some looking into that tomorrow.

@Zuke97
Copy link
Contributor Author

Zuke97 commented Nov 14, 2025

Thanks for the PR. Looking at upstream, they support Header Authentication which would slot in perfectly with our SSO (assuming there is a unique endpoint for public links that could be whitelisted). I'd say that's the preferred method rather than double auth.

Unfortunately the public list endpoint is formatted the same as a regular one (https://wishlist.url/lists/hq7yn45n72).

I think for my use case I'd want it outside of the regular saltbox authentication so I can invite people directly and I don't have to create new users in Authelia. Although, that's my specific use case that could also be handled with inventory tweaks.

@saltydk
Copy link
Member

saltydk commented Dec 3, 2025

@owine you satisfied with that or?

@owine
Copy link
Collaborator

owine commented Dec 4, 2025

I would prefer secured by Authelia by default and the docs can make clear what to add to inventory for public access.

@saltydk
Copy link
Member

saltydk commented Dec 4, 2025

@Zuke97 Then you have your answer.

@Zuke97
Copy link
Contributor Author

Zuke97 commented Dec 11, 2025

I couldn't figure out how to get it to work with the built in SSO so it's a double login now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants