-
-
Notifications
You must be signed in to change notification settings - Fork 105
Added wishlist role #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added wishlist role #494
Conversation
|
Thanks for the PR. Looking at upstream, they support Header Authentication which would slot in perfectly with our SSO (assuming there is a unique endpoint for public links that could be whitelisted). I'd say that's the preferred method rather than double auth. |
|
I think that makes sense for anonymous public lists. I'll do some looking into that tomorrow. |
Unfortunately the public list endpoint is formatted the same as a regular one (https://wishlist.url/lists/hq7yn45n72). I think for my use case I'd want it outside of the regular saltbox authentication so I can invite people directly and I don't have to create new users in Authelia. Although, that's my specific use case that could also be handled with inventory tweaks. |
|
@owine you satisfied with that or? |
|
I would prefer secured by Authelia by default and the docs can make clear what to add to inventory for public access. |
|
@Zuke97 Then you have your answer. |
|
I couldn't figure out how to get it to work with the built in SSO so it's a double login now. |
Description
For the upcoming holidays, created a role for Wishlist to have collaborative wishlists for your friends and family. It has it's own authentication with whoever logging in after first install being able to register themselves as the admin. It also can allow lists to be public, or create invitation links to specific lists.
Docs PR: saltyorg/docs#378
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration. You can use the checkboxes below or delete them as you wish.