Add pH and Temperature as input features to CatPred training pipeline#1
Draft
Add pH and Temperature as input features to CatPred training pipeline#1
Conversation
Co-authored-by: samcogan21 <161603591+samcogan21@users.noreply.github.com>
Co-authored-by: samcogan21 <161603591+samcogan21@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add PH and Temp as input features in CatPred
Add pH and Temperature as input features to CatPred training pipeline
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends CatPred to support pH and temperature as additional molecule-level input features, with optional normalization and seamless integration into the existing feature pipeline.
Changes
Data Layer (
catpred/data/data.py)MoleculeDatapoint: Addedphandtempparams with raw value storage for scalingextend_features_with_ph_temp(): Appends pH/Temp to feature vector (None → 0.0)MoleculeDataset: Addednormalize_ph_temp(),ph_values(),temp_values(),has_ph_temp_features()Arguments (
catpred/args.py)TrainArgs/PredictArgs: Added--ph_column,--temp_column,--no_ph_temp_features_scalingData Loading (
catpred/data/utils.py)'','nan','None','null'→NoneTraining (
catpred/train/run_training.py)Usage
python train.py --data_path data.csv \ --ph_column pH \ --temp_column temperature \ --dataset_type regressionCSV should include the specified columns. Missing values are handled gracefully. Scaling is enabled by default; disable with
--no_ph_temp_features_scaling.Backward Compatibility
All new parameters default to
None—existing workflows unaffected.Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.