Fix duplicate edges in package resolution mode#11
Closed
fank wants to merge 1 commit intosamlitowitz:masterfrom
Closed
Fix duplicate edges in package resolution mode#11fank wants to merge 1 commit intosamlitowitz:masterfrom
fank wants to merge 1 commit intosamlitowitz:masterfrom
Conversation
When using package resolution, the tool was creating one edge per import statement rather than one edge per package dependency. This resulted in duplicate edges when multiple files in a package imported the same target package. For example, if package A had 67 files that imported package B, it would create 67 identical edges from A to B in the graph. This fix deduplicates edges at the package level by tracking unique package-to-package relationships. It also prioritizes cycle edges over normal edges when both exist for the same package pair. Before: - Large codebases could have thousands of duplicate edges - Graph visualization was cluttered and misleading After: - Each package pair has exactly one edge - Cleaner, more accurate package dependency graphs
Author
Owner
|
Resolved by #14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes duplicate edges when using package resolution mode. Previously, the tool created one edge per import statement, resulting in multiple duplicate edges between the same package pairs.
Problem
When using
--resolution package, if package A had multiple files importing package B, the graph would contain multiple identical edges from A to B (one for each import statement). For large codebases, this resulted in thousands of duplicate edges, making the graph cluttered and misleading.For example:
internalhad 67 files importing packagecacheableSolution
Added deduplication logic in
writeRelationshipsForPackageResolution():Results
Testing on a large codebase:
Testing
Tested on the
internal-apicodebase with 306 packages:Verified: