Conversation
|
Last time I checked this links opened as external links in browser (without plugin installed). Can desktop clients recognize them now? |
|
No, and I realized that my regex was a bit messed up, so fixing that now. This would still be an improvement on Android (where you can tell the link to open in the app and it works), and the plugin can force navigation like it did before until a better way is figured out. |
|
I addressed this in the server Samo. This doesn't really add much since it wouldn't work for other users on desktop which is the main feature here. Those links are opened properly if used in the markdown sections of the embed instead of as the title or author url however. So we could add an option to have an additional embed field with name |
183ca07 to
1cf7f30
Compare
|
Ok, regexes are fixed and it actually jumps now with the plugin. I like the body embed idea for people who don't have this installed. |
1cf7f30 to
f8cede9
Compare
|
I have that mostly implemented, but I didn't want to add such a feature until Samogot came back and we could discuss it |
|
Relevant verified bug for this behavior: https://trello.com/c/WD5FyVBu/2124-jump-urls-dont-work-if-masked |
|
The links seem to work on desktop now and web |
|
MERGABLE. This works perfectly |
|
Any update on this? |
|
@Lypheo it works completely fine. I run this version on my client and the links work. |
I think this covers everything backwards-compat wise, if you care about that. All the whitespaces changes are just from
yarn run gulp, so you may want to view the diff with--ignore-space-change.This change is