feat: update realm paths to v2 security-fixed versions#288
Merged
Conversation
Point frontend to the security-fixed v2 candidature and channels realms deployed on test12. The v1 on-chain code had zero ACL checks — v2 adds admin/membership verification on all write operations. Changes: - config.ts: channelsPath/candidaturePath → _v2 paths + env var overrides - parser.ts: fix detectChannelRealm to use MEMBA_DAO.channelsPath instead of hardcoded suffix construction (would never find _v2 path) - gnoweb.test.ts: add v2 realm entries to sample HTML + update assertions - candidatureTemplate.test.ts: tighten default path assertion to v2 - CandidaturePage.test.tsx: update mock to v2 path - .env.example: document VITE_CHANNELS/CANDIDATURE_REALM_PATH overrides - contracts/README.md: full deployment status update (9 realms) Deployed on test12 via samcrew-core-test1 multisig: r/samcrew/memba_dao_candidature_v2 (ACL-fixed) r/samcrew/memba_dao_channels_v2 (ACL-fixed) r/samcrew/nft_market (new) r/samcrew/gnobuilders_badges (new)
✅ Deploy Preview for memba-multisig ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest Buf updates on your PR. Results from workflow CI / proto (pull_request).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detectChannelRealmbug that would silently fail with v2 pathsChanges
config.ts: channelsPath/candidaturePath →_v2paths withVITE_*env var overridesparser.ts: fixdetectChannelRealmto useMEMBA_DAO.channelsPathfrom config instead of hardcoded${daoRealmPath}_channelssuffix (critical — old code would never find v2 path).env.example: document realm path override env varscontracts/README.md: full deployment status for all 9 realmsContext
v1 candidature had zero ACL on MarkApproved/MarkRejected. v1 channels had zero membership checks on all writes. On-chain code is immutable — v2 deployed at new paths via samcrew-deployer PR #9.
Test plan