Json cli#92
Open
ompushkara wants to merge 2 commits intomainfrom
Open
Conversation
ompushkara
force-pushed
the
json-cli
branch
6 times, most recently
from
453ec7f to
4586e90
Compare
- Take JSON input as a flag in addition to the bespoke flags that are already present - Bespoke flags take precedence if the key exists in both - Validates the JSON keys against the flags that already exist as input. Throws error if an invalid option is given as key in JSON - Allow stdin JSON input when --json - is given - Reserve model in --json for MODEL_PATH when no positional; positional wins - Updated README for the --json flag - JSON schema file for validation and editor autocompletion - Add integration tests for JSON input - Add json tests for pkcs11 in test-pkcs11.sh Signed-off-by: ompushkara <omotilal@redhat.com>
Signed-off-by: ompushkara <omotilal@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist