add an --override flag such the base utility.yaml can be extended#2
Open
bikehara-ias wants to merge 1 commit intosamrocketman:mainfrom
Open
add an --override flag such the base utility.yaml can be extended#2bikehara-ias wants to merge 1 commit intosamrocketman:mainfrom
bikehara-ias wants to merge 1 commit intosamrocketman:mainfrom
Conversation
|
|
||
| # Handle YAML merging if requested | ||
| if [ -n "${override_yaml_file:-}" ]; then | ||
| merged_yaml_file="$(mktemp)" |
Owner
There was a problem hiding this comment.
Suggested change
| merged_yaml_file="$(mktemp)" | |
| merged_yaml_file="${TMP_DIR}/merged.yaml" |
TMP_DIR is created for temporary files and is automatically deleted when script exits.
| # Check if next argument exists and doesn't start with -- | ||
| if [ $# -gt 1 ] && [[ ! "$2" =~ ^-- ]]; then | ||
| debug_yaml_file="$2" | ||
| shift |
Owner
There was a problem hiding this comment.
Suggested change
| shift | |
| shift | |
| else | |
| echo "ERROR: A file name is required after --debug-yaml" >&2 | |
| exit 1 |
This helps prevent continuing if the user intended an option but provided an invalid one.
Owner
|
I am going on vacay and will take a deeper look (this was done from mobile). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.