feat: add oops.WrapfWithMetadata #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcondemarin
force-pushed
the
danielcondemarin/oops-err-metadata
branch
from
bf0b752 to
716946f
Compare
danielcondemarin
changed the title
jsm
reviewed
Dec 16, 2024
danielcondemarin
force-pushed
the
danielcondemarin/oops-err-metadata
branch
from
cc40b29 to
d8b91cf
Compare
jsm
approved these changes
Dec 17, 2024
This feature allows decorating oops errors with arbitrary metadata which users can retrieve later for purposes such as logging. - Metadata can be attached to oops errors. (`oops.WrapfWithMetadata`) - Calling `oops.CollectMetadata` retrieves the aggregated metadata for the entire chain.
If CollectMetadata finds a duplicate key in the metadata, it returns the outer most key instead of inner most.
danielcondemarin
force-pushed
the
danielcondemarin/oops-err-metadata
branch
from
79e37ee to
dc682f8
Compare
Improves documentation for CollectMetadata and WrapfWithMetadata
danielcondemarin
force-pushed
the
danielcondemarin/oops-err-metadata
branch
from
dc682f8 to
b7dc60f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows decorating oops errors with arbitrary metadata which users can retrieve later for purposes such as logging.
oops.WrapfWithMetadata)oops.CollectMetadataretrieves the aggregated metadata for the entire chain.