Skip to content

Conversation

@daropotter
Copy link
Contributor

No description provided.

Copy link

@bkosm bkosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preapproving, good luck!

env:
AWS_ACCOUNT_ID: "699475920961"
LAYER_NAME: "ScriptExecutionLambdaSamsaraSDKLayer"
PYTHON_RUNTIME: "python3.11"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use 3.12 in Functions

--layer-name "${LAYER_NAME}" \
--compatible-runtimes "${PYTHON_RUNTIME}" \
--zip-file "fileb://${ARTIFACT_FILE}" \
--description "Built from ${{ github.repository }}@${{ github.sha }}" \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

putting the semantic version of the SDK raw here would be better, this is not user facing anyway

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--description "${{ inputs.sdk_version }}"

dnf -y install python3-pip zip findutils
mkdir -p python
echo \"Installing samsara-python==${SDK_VERSION}\"
python3 -m pip install samsara-python==${SDK_VERSION} -t python
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use python3.12 as the binary here, for clarity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants