Fixed package.json exports to allow for imports of Single Clients#4
Open
Villageslayer wants to merge 2 commits intosamuelspagl:mainfrom
Open
Fixed package.json exports to allow for imports of Single Clients#4Villageslayer wants to merge 2 commits intosamuelspagl:mainfrom
Villageslayer wants to merge 2 commits intosamuelspagl:mainfrom
Conversation
Owner
|
Thanks for Your PR, I'll try to take a Look at it this evening. The project was still on a very Basic Alpha Level, so it is definately missing a few things here and there 😅. I hope that this is Fine ✌️ |
Author
|
The setup and structure looks good and expandable and most important it works. |
samuelspagl
approved these changes
Oct 17, 2025
Owner
samuelspagl
left a comment
There was a problem hiding this comment.
Generally it looks fine to me and I would merge it, the added comment with no line is probably a typo right? 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title Says it all
the export for the Single client was missing from package.json
Before
After