Skip to content

Fixed package.json exports to allow for imports of Single Clients#4

Open
Villageslayer wants to merge 2 commits intosamuelspagl:mainfrom
Villageslayer:main
Open

Fixed package.json exports to allow for imports of Single Clients#4
Villageslayer wants to merge 2 commits intosamuelspagl:mainfrom
Villageslayer:main

Conversation

@Villageslayer
Copy link
Copy Markdown

Title Says it all

the export for the Single client was missing from package.json

Before

"exports": {
        ".": {
            "import": "./dist/index.mjs",
            "require": "./dist/index.cjs"
        },
    },

After

"exports": {
        ".": {
            "import": "./dist/index.mjs",
            "require": "./dist/index.cjs"
        },
        "./scopes": {
            "import": "./dist/scopes/index.mjs",
            "require": "./dist/scopes/index.cjs"
        }
    },

@samuelspagl
Copy link
Copy Markdown
Owner

Hi @Villageslayer

Thanks for Your PR,

I'll try to take a Look at it this evening. The project was still on a very Basic Alpha Level, so it is definately missing a few things here and there 😅.

I hope that this is Fine ✌️

@Villageslayer
Copy link
Copy Markdown
Author

The setup and structure looks good and expandable and most important it works.
Take your time

Copy link
Copy Markdown
Owner

@samuelspagl samuelspagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally it looks fine to me and I would merge it, the added comment with no line is probably a typo right? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants