Reverted find_package() and FindReadline.cmake for finding Readline package. #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions of readline
Copied FindReadline.cmake to ROOT/cmake with appropriate settings in CMakeLists.txt. With this, find_package() load FindReadline.cmake if its logic can't find Readline. This seems to be the most robust way of finding Readline, and remains forward compatible if, and when, the readline package setup is fixed. This is also the solution used by CASACore, which clearly is robust.
preshanth
approved these changes
Jun 12, 2025
Collaborator
preshanth
left a comment
preshanth
left a comment
There was a problem hiding this comment.
This looks good to me and it tests fine. I would encourage you to remove the astron attribution and leave the GNU GPLv3 which allows you to edit and share the file. I would also encourage you to put in a GNU GPLv3 license to the main repo. This works I tested on an rhel8 machine and an ubuntu24.04 container and it runs fine in both cases. I think this is good to go with the license edits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that using the
FindReadline.cmakefromcasacoreand usingfind_package()inCMakeLists.txtworks best. I.e., it has worked on every system or build env that I have used so far.This PR has these two change:
cmake/FindReadline.cmakefromcasacoreCMakeLists.txtand usedfind_package().