Cmake fix #31
Merged
Cmake fix #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions of readline
Copied FindReadline.cmake to ROOT/cmake with appropriate settings in CMakeLists.txt. With this, find_package() load FindReadline.cmake if its logic can't find Readline. This seems to be the most robust way of finding Readline, and remains forward compatible if, and when, the readline package setup is fixed. This is also the solution used by CASACore, which clearly is robust.
1. Added GPL-3.0-only as the license descriptor. 2. url now points to the v1.1.43 release 2. Re-ordered the list of maintainers of the package. This is list of people who maintain the package, not just parafeed.py. 3. Need to use 1.1.43 in `version()`
Updated text about use of `cmake` and some corrections.
Changing to address syntax issue in the github ci. Also swapping the order of environment creationg and sourcing spack setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to ensure CI passes.