Upgrade to Java 17 and Jakarta EE 9+#1
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Upgrade to Java 17 and Jakarta EE 9+#1devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Update Java version from 1.8 to 17 - Update Maven compiler plugin from 3.8.1 to 3.11.0 - Add Maven war plugin 3.4.0 for Java 17 compatibility - Replace javax.servlet:servlet-api:2.3 with jakarta.servlet:jakarta.servlet-api:6.1.0 - Update smiley-http-proxy-servlet from 1.6 to 2.0 - Update commons-validator from 1.4.1 to 1.9.0 - Update basiclti-util to 1.2.1-jakarta-SNAPSHOT (Jakarta EE compatible) - Update web.xml schema from DTD 2.3 to Jakarta EE 6.0 - Migrate all javax.servlet imports to jakarta.servlet in Java files Co-Authored-By: sandeep.parekh@codeium.com <sandeep.parekh@codeium.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the xAPI LMS Integration application from Java 8 to Java 17 LTS and migrates from
javax.servlet(Servlet API 2.3) tojakarta.servlet(Jakarta EE 9+). This is a "Traditional Upgrade" that maintains the existing WAR deployment architecture while modernizing the Java stack.Key changes:
javax.servlet:servlet-api:2.3→jakarta.servlet:jakarta.servlet-api:6.1.0javax.servlet.*imports migrated tojakarta.servlet.*Review & Testing Checklist for Human
basiclti-util:1.2.1-jakarta-SNAPSHOTdependency was built locally from a modified version of the basiclti-util-java library. CI will fail because this artifact is not available in Maven Central. You'll need to either: (1) publish the Jakarta-compatible version to a repository, (2) include the modified basiclti-util-java as a submodule, or (3) find an alternative LTI library that supports Jakarta EE.Notes
The upstream basiclti-util-java library has not been updated for Jakarta EE. To make this upgrade work, I modified a local copy of that library to use
jakarta.servletinstead ofjavax.servletand installed it to the local Maven repository. This is a temporary workaround that needs a proper solution before merging.Link to Devin run: https://app.devin.ai/sessions/6503e1b8fdf240ca9243a9664d978ac3
Requested by: @sandeepparekh-droid