Added CombatManagerService and pulled out core functionality from UI#29
Open
herrozerro wants to merge 1 commit intosander1095:devfrom
Open
Added CombatManagerService and pulled out core functionality from UI#29herrozerro wants to merge 1 commit intosander1095:devfrom
herrozerro wants to merge 1 commit intosander1095:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a CombatManagerService that exposes the core functionality.
Stripped out any references to the above in the GUI and let the service manage the combat. The GUI still has a lot of UI specific code which is fine. But using this service it can be extended to other UIs
I don't know if this satisfies #5 or not, but if not maybe it should be changed to drop the WPF, as this commit puts core functionality into a service and can be used in other patterns including MVVM for WPF.