Working on updating the numpy requirement since v1 is no longer suppo…#327
Open
jehsharp wants to merge 3 commits intosandialabs:developfrom
Open
Working on updating the numpy requirement since v1 is no longer suppo…#327jehsharp wants to merge 3 commits intosandialabs:developfrom
jehsharp wants to merge 3 commits intosandialabs:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to build off of Alex's work on updating code to be compliant with NumPy 2.0 and above. Changing np.float_ to np.float64 does not break backwards capabilities, as np.float64 is valid and works also in NumPy 1.0.
Summary of changes
Updated the last 3 instances of np.float_ to np.float64 and updated the NumPy requirement in requirements.txt.
Implementation notes
Please describe any relevant implementation details for reviewers, e.g. how correctness was verified.
Submission checklist
develop, notmainopencsp/test/test_DocStringsExist.pyare verified to include this change or have been updated accordinglydoc/are verified to include this change or have been updated accordinglyAdditional information
Please provide any additional information here.