adding dof manager to params and re-writing params as an equinox module#111
Open
adding dof manager to params and re-writing params as an equinox module#111
Conversation
…le to allow for this
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
- Coverage 77.26% 77.25% -0.02%
==========================================
Files 62 62
Lines 5230 5267 +37
==========================================
+ Hits 4041 4069 +28
- Misses 1189 1198 +9 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two main things:
Why did I do this?
With the current setup, if you want to change Dirichlet BCs, you'd need to redefine all energy functions, etc. that implicitly use the DofManager. Now we can just create a new DofManager with the new desired BCs and update this in Params. This will of course likely lead to re-jitting whenever the DofManager changes which should at most be a handful of times even in the most complex analyses.