Y26-061 Bioscan - submission button not showing#2747
Y26-061 Bioscan - submission button not showing#2747andrewsparkes wants to merge 9 commits intodevelopfrom
Conversation
…how child PCR 1 button unless there is an active library prep request
…ission-button-not-showing
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2747 +/- ##
===========================================
+ Coverage 84.93% 84.98% +0.04%
===========================================
Files 501 504 +3
Lines 20600 20667 +67
Branches 377 377
===========================================
+ Hits 17497 17564 +67
Misses 3100 3100
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Have tested the following pipelines that are using SubmissionBehaviour module by running their integration suite tests: Plates: Tubes: |
yoldas
left a comment
yoldas
left a comment
There was a problem hiding this comment.
Well designed, documented, and tested.
| module Presenters | ||
| # | ||
| # This version of the Presenter is for Bioscan, to only show the PCR 1 plate creation button | ||
| # if there are valid lirbary prep requests. |
| end | ||
|
|
||
| context 'when not all submissions are ready' do | ||
| let(:submissions) { [build(:submission, ready?: false)] } |
There was a problem hiding this comment.
note: ready? is a delegate to :state on Sequencescape::Api::V2::Submission
2 participants
Closes #2726
Changes proposed in this pull request
Includes the Y26-062 branch that includes checks to display PCR 1 child creation button.
Instructions for Reviewers
See associated integration suite PR here