Skip to content

[ux] Update sample accessioning message#5633

Open
StephenHulme wants to merge 5 commits intodevelopfrom
sh51/update-sample-accessioning-message
Open

[ux] Update sample accessioning message#5633
StephenHulme wants to merge 5 commits intodevelopfrom
sh51/update-sample-accessioning-message

Conversation

@StephenHulme
Copy link
Contributor

Addresses misleading wording raised in https://sanger.freshservice.com/a/tickets/58471?current_tab=details

Changes proposed in this pull request

  • Improve reability of Study Specifications page (note gaps between fields)
  • Modernise specifications page
  • Add study accessioning checklist to specifications page
  • Change message on unassionable samples:
    • from Study 'UAT Study' is missing an accession number
    • to Study 'UAT Study' is not accessionable - <view accessioning checklist>

Developer notes

  • The studies information page is overcrowded and it isn't possible to link to a specific tab, in this case the Studies Accessioning checklist.
  • The studies information page is more for samples anyway... so I've added the checklist to the Study Detail/Specification/Properties page, where it can be linked too.
  • But adding it to the study specification page looked weird, since the page was so dated - so I fixed that too 😅

Screenshots

Before:
Screenshot 2026-03-20 at 16 47 44

image

After:
Screenshot 2026-03-20 at 16 41 30

image

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@StephenHulme StephenHulme self-assigned this Mar 20, 2026
@StephenHulme StephenHulme added UX Improves user experience Accessioning Epic in technical roadmap June 2025, relating to improving the accessioning code. labels Mar 20, 2026
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.21%. Comparing base (b37ffd9) to head (9b1b1d8).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5633      +/-   ##
===========================================
- Coverage    87.23%   87.21%   -0.03%     
===========================================
  Files         1461     1461              
  Lines        33012    33014       +2     
  Branches      3472     3472              
===========================================
- Hits         28798    28792       -6     
- Misses        4193     4201       +8     
  Partials        21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accessioning Epic in technical roadmap June 2025, relating to improving the accessioning code. UX Improves user experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant