Workaround for TIDAL's non-compliant streaming manifest#64
Merged
sangwonl merged 1 commit intosangwonl:masterfrom Jan 18, 2026
Merged
Conversation
As of January 2026, TIDAL started publishing non-compliant streaming
manifests:
```xml
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<MPD ...>
<Period id="0">
<AdaptationSet contentType="audio" group="main" id="0" lang="und" mimeType="audio/mp4" segmentAlignment="true">
<!-- ... -->
</AdaptationSet>
</Period>
</MPD>
```
According to the MPEG-DASH specs `AdaptationSet@group` should be an
integer (and that's how this library implements it).
But in this case it's a string, and that ends up breaking the manifest
parsing logic.
This commit implements a fallback that tries to parse it as a string if
the compliant cast fails.
This was referenced Jan 18, 2026
Owner
|
Thanks for the contribution! I took a closer look since accepting non-compliant values is always a tradeoff. Here's my take:
Would be nice to have a test case covering this, but not a blocker. LGTM 👍 |
sangwonl
approved these changes
Jan 18, 2026
slaythrax
added a commit
to slaythrax/high-tide
that referenced
this pull request
Jan 19, 2026
Solve the Hi-Res issue updating to the latest mpegdash version. That solves the Tidal manifest issues sangwonl/python-mpegdash#64
blacklight
added a commit
to blacklight/python-tidal
that referenced
this pull request
Jan 19, 2026
This fixes the issue with non-compliant DASH manifests being sent by TIDAL as of 2026-01-15. Context: sangwonl/python-mpegdash#64 Closes: EbbLabs#396
haginrich
pushed a commit
to haginrich/high-tide
that referenced
this pull request
Jan 20, 2026
Solve the Hi-Res issue updating to the latest mpegdash version. That solves the Tidal manifest issues sangwonl/python-mpegdash#64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of January 2026, TIDAL started publishing non-compliant streaming manifests:
According to the MPEG-DASH specs
AdaptationSet@groupshould be an integer (and that's how this library implements it).But in this case it's a string, and that ends up breaking the manifest parsing logic.
This commit implements a fallback that tries to parse it as a string if the compliant cast fails.
Closes: EbbLabs/python-tidal#396