Fix deprecated/lint warnings with ansible 2.12+#22
Open
ocroz wants to merge 1 commit intosansible:developfrom
Open
Fix deprecated/lint warnings with ansible 2.12+#22ocroz wants to merge 1 commit intosansible:developfrom
ocroz wants to merge 1 commit intosansible:developfrom
Conversation
Author
|
Hello @dennisconrad, or whoever contributor to this project, I corrected few annoying deprecated and lint warnings that it would be interesting to integrate into a new release. Happy to help, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most annoying with ansible-playbook:
Then with ansible-lint:
# ansible-lint roles/sansible.logrotate/tasks/* WARNING Listing 9 violation(s) that are fatal fqcn[action-core]: Use FQCN for builtin module actions (package). roles/sansible.logrotate/tasks/build.yml:3 Use `ansible.builtin.package` or `ansible.legacy.package` instead. fqcn[action-core]: Use FQCN for builtin module actions (template). roles/sansible.logrotate/tasks/configure.yml:3 Use `ansible.builtin.template` or `ansible.legacy.template` instead. risky-file-permissions: File permissions unset or incorrect. (warning) roles/sansible.logrotate/tasks/configure.yml:3 Task/Handler: Configure Application Logs Logrotate Config fqcn[action-core]: Use FQCN for builtin module actions (template). roles/sansible.logrotate/tasks/configure.yml:10 Use `ansible.builtin.template` or `ansible.legacy.template` instead. risky-file-permissions: File permissions unset or incorrect. (warning) roles/sansible.logrotate/tasks/configure.yml:10 Task/Handler: Configure Custom Logrotate Configs deprecated-module: Deprecated module. include roles/sansible.logrotate/tasks/main.yml:3 Task/Handler: Install logrotate fqcn[action-core]: Use FQCN for builtin module actions (include). roles/sansible.logrotate/tasks/main.yml:3 Use `ansible.builtin.include` or `ansible.legacy.include` instead. deprecated-module: Deprecated module. include roles/sansible.logrotate/tasks/main.yml:8 Task/Handler: Configure logrotate fqcn[action-core]: Use FQCN for builtin module actions (include). roles/sansible.logrotate/tasks/main.yml:8 Use `ansible.builtin.include` or `ansible.legacy.include` instead. You can skip specific rules or tags by adding them to your configuration file: # .config/ansible-lint.yml warn_list: # or 'skip_list' to silence them completely - deprecated-module # Deprecated module. - experimental # all rules tagged as experimental - fqcn[action-core] # Use FQCN for builtin actions. Rule Violation Summary count tag profile rule associated tags 2 deprecated-module basic deprecations 2 risky-file-permissions safety unpredictability, experimental (warning) 5 fqcn[action-core] production formatting