Skip to content

[codex] Add rejected and discarded pipeline tabs#348

Open
BobbyWang0120 wants to merge 1 commit intosantifer:mainfrom
BobbyWang0120:codex/pipeline-terminal-tabs
Open

[codex] Add rejected and discarded pipeline tabs#348
BobbyWang0120 wants to merge 1 commit intosantifer:mainfrom
BobbyWang0120:codex/pipeline-terminal-tabs

Conversation

@BobbyWang0120
Copy link
Copy Markdown
Contributor

@BobbyWang0120 BobbyWang0120 commented Apr 17, 2026

Summary

  • add REJECTED and DISCARDED tabs to the pipeline top navigation
  • keep those terminal states directly reachable with left/right tab navigation
  • add a regression test that verifies each new tab isolates the matching status rows

Testing

  • cd dashboard && go test ./...
  • cd dashboard && go build ./...

Bug-fix note: this is a small dashboard UX gap fix, so I did not open a separate issue.

Summary by CodeRabbit

  • New Features

    • Added "Rejected" and "Discarded" filter tabs to the pipeline view, letting users filter and organize applications by these additional status categories.
  • Tests

    • Added test coverage verifying the new filter tabs correctly return only applications with "Rejected" or "Discarded" status.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: dea114bf-39ee-4938-a391-34a010acf9f9

📥 Commits

Reviewing files that changed from the base of the PR and between 42d9d88 and 5d0c8ea.

📒 Files selected for processing (2)
  • dashboard/internal/ui/screens/pipeline.go
  • dashboard/internal/ui/screens/pipeline_test.go

📝 Walkthrough

Walkthrough

Two new pipeline filter modes, rejected and discarded, were added as tabs labeled REJECTED and DISCARDED. The pipeline filtering logic was extended to consider these normalized status values, and tests were added to verify filtering for those statuses.

Changes

Cohort / File(s) Summary
Pipeline Core
dashboard/internal/ui/screens/pipeline.go
Added two new filter mode constants (rejected, discarded) and appended pipeline tabs with labels REJECTED and DISCARDED. The filter-selection logic now supports these additional normalized status values.
Pipeline Tests
dashboard/internal/ui/screens/pipeline_test.go
Added helper tabIndexForFilter() and TestRejectedAndDiscardedTabsFilterCorrectly which seeds applications with Rejected, Discarded, and Applied statuses and asserts filtering returns the correct rows for each new tab.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

📊 dashboard

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding rejected and discarded pipeline tabs to the dashboard navigation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@BobbyWang0120 BobbyWang0120 force-pushed the codex/pipeline-terminal-tabs branch from 42d9d88 to 5d0c8ea Compare April 19, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant