Release please branches main#400
Closed
fahimimtiaz12 wants to merge 12 commits intosantifer:release-please--branches--mainfrom
Closed
Release please branches main#400fahimimtiaz12 wants to merge 12 commits intosantifer:release-please--branches--mainfrom
fahimimtiaz12 wants to merge 12 commits intosantifer:release-please--branches--mainfrom
Conversation
Added multiple companies with their careers URLs, scan methods, and notes to the portals configuration.
Add new company entries to portals.example.yml
chore(main): release 1.6.0
chore(main): release 1.6.0
📝 WalkthroughWalkthroughThis release updates the project version to 1.7.0 across manifest and changelog files, introduces a new contributors documentation file, and consolidates the example portal configuration by removing seven tracked companies while normalizing quote formatting. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.release-please-manifest.json:
- Line 2: The repository release metadata was bumped to "1.7.0" in
.release-please-manifest.json but the canonical VERSION file still contains
1.3.0; update the VERSION file to 1.7.0 to synchronize version sources and
ensure any other single-source-of-truth (e.g., package.json, setup.cfg, or other
VERSION constants) also reflect 1.7.0. Locate the VERSION file and replace its
contents with 1.7.0 (and run any project version update script if present) so
all version references (the "." entry in .release-please-manifest.json and the
VERSION file) match.
In `@CHANGELOG.md`:
- Around line 8-19: Deduplicate duplicate bullets by collapsing entries that
reference the same commit hash into a single line and include both issue
numbers; e.g., for commit 0853486 combine the two "add Gemini CLI native
integration" bullets into one line listing both issue links (`#349` and `#344`) plus
the commit hash, for commit b824953 combine the two LaTeX/Overleaf bullets and
include both issue refs (`#362` and `#47`), and for commits 7c5fecb and 3a4c596
merge their duplicated Bug Fix bullets to single lines listing both issue links
(`#343` and `#352` for 7c5fecb; `#358` and `#359` for 3a4c596) so each commit appears
only once in the changelog.
- Line 3: The changelog entry uses the wrong repository host in the compare URL;
update the URL in the header string "##
[1.7.0](https://github.com/fahimimtiaz12/career-ops/compare/v1.6.0...v1.7.0)" to
the canonical host used by the project (replace "fahimimtiaz12/career-ops" with
"santifer/career-ops") so the compare link matches other metadata and scripts.
- Around line 21-119: The changelog contains a duplicated release block for "##
[1.6.0](https://github.com/fahimimtiaz12/career-ops/compare/v1.5.0...v1.6.0)" —
remove the second repeated block (the duplicate starting at the second "##
[1.6.0]" heading and its following Features/Bug Fixes/Performance Improvements
lists) so only one canonical 1.6.0 section remains, preserving the original
entries and ordering.
In `@CONTRIBUTORS.md`:
- Line 7: Update the phrasing in CONTRIBUTORS.md that currently reads "Full
authority over content direction within their scope." to explicitly defer final
decision-making to the project's governance document (GOVERNANCE.md); replace
the "Full authority" language with a sentence such as "Primary technical
stewardship for their area, subject to final governance and decision rights as
defined in GOVERNANCE.md" so contributors retain clear ownership while aligning
decision authority with the BDFL + contributor ladder described in
GOVERNANCE.md.
In `@templates/portals.example.yml`:
- Around line 813-817: The Perplexity YAML entry is mis-indented and a preceding
PR/batch rationale comment line is breaking YAML parsing; fix by de-denting the
"name: Perplexity" line and its following keys (careers_url, scan_method,
scan_query) so they are top-level sequence items matching other company entries,
and remove or move the freeform rationale comment line so the file contains only
valid YAML mappings for the "name: Perplexity" block.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 55a47343-0267-45d5-898e-271d216e0ce7
📒 Files selected for processing (4)
.release-please-manifest.jsonCHANGELOG.mdCONTRIBUTORS.mdtemplates/portals.example.yml
|
|
||
| ## Core Contributors | ||
|
|
||
| Contributors with sustained technical ownership over specific areas. Full authority over content direction within their scope. |
There was a problem hiding this comment.
Align authority wording with project governance.
Line 7 grants “Full authority,” which conflicts with the documented BDFL + contributor ladder governance model and may create decision-rights ambiguity. Prefer wording that explicitly defers final governance authority to GOVERNANCE.md.
Suggested wording
-Contributors with sustained technical ownership over specific areas. Full authority over content direction within their scope.
+Contributors with sustained technical ownership over specific areas. They lead decisions in their scope in alignment with the project governance model defined in GOVERNANCE.md.Based on learnings: "use BDFL governance model with contributor ladder (Participant → Contributor → Triager → Reviewer → Maintainer, see GOVERNANCE.md)".
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| Contributors with sustained technical ownership over specific areas. Full authority over content direction within their scope. | |
| Contributors with sustained technical ownership over specific areas. They lead decisions in their scope in alignment with the project governance model defined in GOVERNANCE.md. |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@CONTRIBUTORS.md` at line 7, Update the phrasing in CONTRIBUTORS.md that
currently reads "Full authority over content direction within their scope." to
explicitly defer final decision-making to the project's governance document
(GOVERNANCE.md); replace the "Full authority" language with a sentence such as
"Primary technical stewardship for their area, subject to final governance and
decision rights as defined in GOVERNANCE.md" so contributors retain clear
ownership while aligning decision authority with the BDFL + contributor ladder
described in GOVERNANCE.md.
Comment on lines
+813
to
+817
| # -- This batch is clean and consistent with the existing style, and each company has a live careers board/result that matches the repo’s AI / automation / developer-tool focus. Perplexity uses Ashby and has roles like Forward Deployed Engineer / Applied AI; Clay Labs uses Ashby and shows engineering plus AI-adjacent roles; Runway uses Greenhouse; Hightouch uses Greenhouse and shows Solutions Engineer plus AI Agents roles; WorkOS uses Ashby and shows Solutions Engineer / developer-tool roles. -- | ||
| - name: Perplexity | ||
| careers_url: https://jobs.ashbyhq.com/perplexity | ||
| scan_method: websearch | ||
| scan_query: ‘site:jobs.ashbyhq.com/perplexity "AI" OR "Applied AI" OR "Forward Deployed" OR "Engineer"’ | ||
| scan_query: 'site:jobs.ashbyhq.com/perplexity "AI" OR "Applied AI" OR "Forward Deployed" OR "Engineer"' |
There was a problem hiding this comment.
Fix the Perplexity entry indentation; this currently breaks YAML parsing.
Line 814 is indented as a nested sequence under the previous company entry, so templates/portals.example.yml is invalid YAML. This will block users after copying it to portals.yml, which scan.mjs parses at startup.
Also, Line 813 reads like PR/batch rationale and can become stale in this auto-updatable template.
Proposed fix
- # -- This batch is clean and consistent with the existing style, and each company has a live careers board/result that matches the repo’s AI / automation / developer-tool focus. Perplexity uses Ashby and has roles like Forward Deployed Engineer / Applied AI; Clay Labs uses Ashby and shows engineering plus AI-adjacent roles; Runway uses Greenhouse; Hightouch uses Greenhouse and shows Solutions Engineer plus AI Agents roles; WorkOS uses Ashby and shows Solutions Engineer / developer-tool roles. --
- - name: Perplexity
+ # -- AI / Developer Tools --
+ - name: Perplexity
careers_url: https://jobs.ashbyhq.com/perplexity
scan_method: websearch
scan_query: 'site:jobs.ashbyhq.com/perplexity "AI" OR "Applied AI" OR "Forward Deployed" OR "Engineer"'As per coding guidelines, templates/portals.example.yml should stay auto-updatable and YAML configuration must remain valid.
🧰 Tools
🪛 YAMLlint (1.38.0)
[error] 814-814: syntax error: expected , but found '-'
(syntax)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@templates/portals.example.yml` around lines 813 - 817, The Perplexity YAML
entry is mis-indented and a preceding PR/batch rationale comment line is
breaking YAML parsing; fix by de-denting the "name: Perplexity" line and its
following keys (careers_url, scan_method, scan_query) so they are top-level
sequence items matching other company entries, and remove or move the freeform
rationale comment line so the file contains only valid YAML mappings for the
"name: Perplexity" block.
github-actions
Bot
force-pushed
the
release-please--branches--main
branch
from
82c247d to
290acd8
Compare
Owner
|
Hey @fahimimtiaz12 — closing this one since it looks like an accidental push from syncing your fork's main with Release Please. The automated release PR is already here: #375 (from Your real work is tracked in your other open PRs (#299, #300, #301) — focus there. No harm done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related issue
Type of change
Checklist
node test-all.mjsand all tests passQuestions? Join the Discord for faster feedback.
Summary by CodeRabbit
Chores
Documentation