Draft
Conversation
cpp17: remove depracated class and unused variable
promoting the MCParticles from pointers to objects does not allow for serialization of the TRefArray, for this reason I am dropping it
…uproot and awkward
this means we effectively have two cutflows, one selecting vertices and one selecting events, both are stored separately
so we can make a plot showing the effect of the preselection
- remove old time bias members - remove pause for user inspection of json - add warning if correction does not match one of the known names - apply the new map of corrections to the actual tracks
only copy this truth particle for the signal samples, this lightens the final analysis tuples and helps simplify the final analysis since we don't have to sift through all the MC particles to find the only one we care about. Impose a requirement that one and exactly one true Vd is the in the event. This is necessary for decay re-weighting and the very rare events where there are zero or more than one Vd pale in comparison to the requirement of a reconstructed vertex
need to update code that checks track data format so that it allows for an additional float index
I did this out of desparation since it was the only difference left I could think of between Alic's and my vertex pre-selection. It works though which is very unsettling, but I'm going to ignore those feelings.
this separate correction of the track is necessary for real data where the beamspot slightly varies as a function of run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FOR COMPARISON ONLY -- DO NOT MERGE