Open
Conversation
Supreeth10
reviewed
Dec 3, 2022
| render(<App />); | ||
| const question = screen.getByText('Enter number of people involved in the transaction?') | ||
| expect(question).toBeInTheDocument(); | ||
| const inputBox = screen.getByRole('spinbutton',{name:'Enter number of people involved in the transaction?'}) |
Collaborator
There was a problem hiding this comment.
Optional- I would add a condition here to make sure the number of people selected is not negative.
Collaborator
There was a problem hiding this comment.
Agreed. I suggest the same, a test for the negative number could be added.
Supreeth10
approved these changes
Dec 3, 2022
Collaborator
Supreeth10
left a comment
Supreeth10
left a comment
There was a problem hiding this comment.
Added a comment, other than that it looks good to me.
VnvsTejesh
reviewed
Dec 3, 2022
| render(<App />); | ||
| const question = screen.getByText('Enter number of people involved in the transaction?') | ||
| expect(question).toBeInTheDocument(); | ||
| const inputBox = screen.getByRole('spinbutton',{name:'Enter number of people involved in the transaction?'}) |
Collaborator
There was a problem hiding this comment.
I would suggest to add test for scrollbar when you enter bigger number. Apart from that everything looks good to me.
VnvsTejesh
approved these changes
Dec 3, 2022
Pranav-PSU
reviewed
Dec 3, 2022
| <input id='personNumber' name='personNumber' type="number" onChange={onNumberChange} /> | ||
| </div> | ||
| {numberOfPeople > 0 && ( | ||
| <div className="row"> |
Pranav-PSU
approved these changes
Dec 3, 2022
Collaborator
Pranav-PSU
left a comment
Pranav-PSU
left a comment
There was a problem hiding this comment.
- Suggestion: A test for the negative number could be added in App.test.js
-everything else looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test whether