This repository was archived by the owner on Sep 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
Fixed emoji support for python-3.8, added use_emoji from initializer, added custom disabling_notification #26
Open
GabrieleCalarota
wants to merge
11
commits into
sashgorokhov:master
Choose a base branch
from
SquisEat:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed emoji and added some more emoji for every level added support for use_emoji from initializer added support for disabling notification under certain level
Author
|
Example of usage: Will use emoji, support for logging level up to DEBUG, disabling notification is False, so setting level of disabling notification only in DEBUG and INFO log, from WARNING up to CRITICAL will sound notification. Also added use_emoji set default value to True |
…able to set this parameter in yaml overriding)
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
- Coverage 98.36% 90.72% -7.64%
==========================================
Files 4 5 +1
Lines 122 151 +29
==========================================
+ Hits 120 137 +17
- Misses 2 14 +12
Continue to review full report at Codecov.
|
1c7c091 to
2a12c70
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed emoji and added some more emoji for every level
added support for use_emoji from initializer
added support for disabling notification under certain level
Fixing issue #25