Add common Sass TypeScript configuration to the analysis package #2333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Sep 18, 2025
| "copyfiles": "^2.4.1", | ||
| "eslint-plugin-import": "^2.30.0", | ||
| "expect": "^29.7.0", | ||
| "gts": "^5.0.0", |
There was a problem hiding this comment.
is it needed to still have a direct dependency on ègts or is the transitive dependency enough (sass-analysiswill use its owngts` dependency)
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "extends": "./node_modules/gts/tsconfig-google.json" | |||
There was a problem hiding this comment.
does this work if gts is hoisted differently ? It should probably use gts/tsconfig-google.json instead, relying on the node-style resolution of the package
|
Unfortunately, it seems that gts is still not compatible with eslint flat configs (google/gts#830). I don't think we can land this without either that or moving away from GTS entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.