Make misplaced rest arguments a syntax error #2623
Merged
+38
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
reviewed
Aug 23, 2025
CHANGELOG.md
Outdated
| @@ -1,3 +1,11 @@ | |||
| ## 1.92.0 | |||
There was a problem hiding this comment.
1.91.0 has not been tagged. So you might want to combine this into 1.91.0?
|
Hmm... the fact that this was used apparently on purpose in Compass makes me more nervous about landing it without a deprecation. Maybe we should delay the breakage until Dart Sass 2. |
This was referenced Aug 23, 2025
Goodwine
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass#4120
See sass/sass-spec#2072
See sass/sass#4121
See #2624