Skip to content

Fix for "too many open files" error on OSX. #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for "too many open files" error on OSX. #3183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/file.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
# define S_ISDIR(mode) (((mode) & S_IFMT) == S_IFDIR)
#else
# include <unistd.h>
# include <fcntl.h>
#endif
#include <cstdio>
#include <vector>
Expand Down Expand Up @@ -469,6 +470,20 @@ namespace Sass {
CloseHandle(hFile);
// just convert from unsigned char*
char* contents = (char*) pBuffer;
#elif __APPLE__
// On OSX `fopen` can fail with "too many open files" but succeeds using `open`.
struct stat st;
if (stat(path.c_str(), &st) == -1 || S_ISDIR(st.st_mode)) return 0;
int file = open(path.c_str(), O_RDONLY);
char* contents = 0;
if (file != -1) {
size_t size = st.st_size;
contents = (char*) malloc((size+2)*sizeof(char));
read(file, contents, size);
contents[size+0] = '\0';
contents[size+1] = '\0';
close(file);
}
#else
// Read the file using `<cstdio>` instead of `<fstream>` for better portability.
// The `<fstream>` header initializes `<locale>` and this buggy in GCC4/5 with static linking.
Expand Down