feat(abort): make abort reason customizable#4
Open
javiercejudo wants to merge 1 commit intosathify:masterfrom
Open
feat(abort): make abort reason customizable#4javiercejudo wants to merge 1 commit intosathify:masterfrom
javiercejudo wants to merge 1 commit intosathify:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Could just be:
function getRejectReason (reason) {
return reason || DEFAULT_REASON
}
Author
There was a problem hiding this comment.
Someone might want to make the reason 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is backwards compatible. The use case is to make it easier for devs to have different logic depending on the reason a request was aborted.