first step to handle discontinuated/split entities#22
Open
jeanphilippegoldman wants to merge 3 commits intosavkov:masterfrom
Open
first step to handle discontinuated/split entities#22jeanphilippegoldman wants to merge 3 commits intosavkov:masterfrom
jeanphilippegoldman wants to merge 3 commits intosavkov:masterfrom
Conversation
-ignore attribute annotations (lines starting with A)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added self.frag to Annotation constructor as a list of fragments, each of them being (start_idx,end_idx) pair. and kept self.start_idx (resp. self.end_idx) as the start (resp. end) of first (resp. last) fragment.
In most of the case, there's only one fragment.
Some comparisons in agreement.py should be a bit better handled (is_contained_by, contains_ann,, is_partial_to, overlaps_with, has_partial_candidate, is_right_from, in_range) but at list , discont. entities are handled.
Maybe some additionnal testing could be welcomed
Also, I added an exception to skip lines of .ann files starting with an A (for attributes)