Skip to content

Conversation

@bryananderson
Copy link
Contributor

Fixes bug in Spanish currency handling when there is no cents part of the value

Changes proposed in this pull request:

  • Now we check if there is a cents part before we try to access it

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Run tests (added integer test cases)

@bryananderson
Copy link
Contributor Author

I also want to note that base.py here calls parse_currency_parts() here which will assume that an integer value means cents rather than dollars/euros/etc--this is not intuitive to me at all, is it the desired behavior?

@coveralls
Copy link

coveralls commented Jan 16, 2025

Coverage Status

coverage: 98.118%. remained the same
when pulling 21c6eac on bryananderson:spanish-no-cents
into 46c9580 on savoirfairelinux:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants