Fixes #552 by Paola L. & Sydney F. #632
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #552
Fixes #552 by Paola L. & Sydney F.
Changes proposed in this pull request:
Status
How to verify this change
To verify the fix for the diciotto issue, we wrote unit tests for numbers like 118, 218, ..., 918, confirming that they correctly return "diciotto" instead of the incorrect "dicotto". We also tested other cases like 28, 88, and 21 to ensure valid phonetic contractions still work as expected. To manually verify this fix, you can run num2words(, lang="it") with any number ending in 18, and it should correctly preserve "diciotto" in the output. All tests passed, confirming the fix is working and safe.
Additional notes
If applicable, explain the rationale behind your change.