test(chinese): Attempt at adding tests for the chinese regex match#73
Open
markscamilleri wants to merge 1 commit intosawhney17:mainfrom
Open
test(chinese): Attempt at adding tests for the chinese regex match#73markscamilleri wants to merge 1 commit intosawhney17:mainfrom
markscamilleri wants to merge 1 commit intosawhney17:mainfrom
Conversation
|
I've created fork with supporting of languages (Russian, Chinese, Korean, Japanese, German) https://github.com/the-homeless-god/logseq-automatic-linker-international So you can just take a look into it Looks like the original repo not has updates since long time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I noticed while testing #72 that this piece of code:
was not actually tested anywhere.
Solution
This is my attempt at adding a couple of tests for this secton of code.
Apologies and Disclaimer
However, I am not a native Chinese, Japanese, Korean or Vietnamese speaker, and this was a best guess based on the official unicode table and the Cabridge English <-> Chinese (Simplified) dictionary, so if this is not right for any reason, please feel free to edit the PR and/or feedback here please! The aim here is to avoid any regression from getting introduced in the future.
Question
I also noticed that the unicode tables go all the way to
\u9ffffor CJKV characters/ideographs. Should we expand the scope of thechineseRegexto match this?