Skip to content

Feature/checkinstall#8

Open
nyxrobotics wants to merge 3 commits intox-seriesfrom
feature/checkinstall
Open

Feature/checkinstall#8
nyxrobotics wants to merge 3 commits intox-seriesfrom
feature/checkinstall

Conversation

@nyxrobotics
Copy link

Summary

Fix #7

Detail

  • Add sudo ./waf checkinstall command for Debian/Ubuntu.
  • Update README.md

Copy link

@jsupratman13 jsupratman13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

実機で問題がなく動けました

Copy link

@ssr-yuki ssr-yuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your change sets the package name to dynamixel-demos but this is just name of a sample binary. In fact, this is LIBRARY named 'libdynamixel'. Using APPNAME as a package name is not appropriate.

@nyxrobotics
Copy link
Author

APPNAME was not used in libdynamixel.
There is no need to keep the name dynamixel-demos, so APPNAME was changed to libdynamixel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

依存関係解決・Checkinstall対応

3 participants