ENH: filter grants collection for co-PIs of person #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- working on fixing cells with data validation
- reformatted the names into Last, First format - sorted the names by alphabetical order (by last name)
- added .idea to .gitignore - modified coabuilder.py: added option for finding collaborators within 48 months from a provided "to date"
… files). Test passed for now."
coabuilder.py modifications (see below)
…into recent_collaborators
sbillinge
reviewed
Mar 18, 2020
Owner
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
I think this needs a bit of discussion. I am not too happy about this filter function in the first place. I think it is supposed to return a list of grants that contain a person but it is clujy. We might want to split it up and for example, filter for "all the grants that a person is in" which should return a list of grants. Let's maybe schedule a call for this.
Author
|
Sorry I am a bit confused now. Then it seems like your original filter function could already do that? or maybe I am wrong? We could input the |
Owner
|
no, my original filter is not good, I wonder if this is a good time to fix
it.
…On Wed, Mar 18, 2020 at 4:29 PM longyang ***@***.***> wrote:
Sorry I am a bit confused now. Then it seems like your original filter
function could already do that? or maybe I am wrong? We could input the
names as the person name you want, then the output grants are the grants
includes that person.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWUL5SOVY4O2EKCPUSYLRIEVJRANCNFSM4LOYC5JQ>
.
--
Professor Simon Billinge
Columbia University
|
Author
|
I see. can you write some more detailed words on what you want from this function? inputs and outputs expected. |
Owner
|
let me think about it and I can give a guidance
…On Wed, Mar 18, 2020 at 4:39 PM longyang ***@***.***> wrote:
I see. can you write some more detailed words on what you want from this
function? inputs and outputs expected.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWUOSEDC32VOWPP3WBTLRIEWQBANCNFSM4LOYC5JQ>
.
--
Professor Simon Billinge
Columbia University
|
sbillinge
force-pushed
the
recent_collaborators
branch
from
13a36ad to
3e0ebc5
Compare
sbillinge
force-pushed
the
recent_collaborators
branch
from
7ee23f8 to
7983fdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sbillinge , this PR is to close issue regro#298 that @rohanpok and I worked together. Please review and merge.
We use
co_pisdictionary to record every co-PIs grant amount.