Sync History #87
Sync History #87
Conversation
| return; | ||
| } | ||
|
|
||
| // If the metadata is synced first then we can't state if a sync was successful or not. Unless it is uploaded again after? |
There was a problem hiding this comment.
We probably need to upload metadata after a sync, I think this makes sense to me.
Some failed syncs may result in metadata not being uploaded, which is acceptable (not all failures can be sent remotely, like if remote isn't responding or we don't have internet connection).
If a sync fails and we can't send that to the remote can we still show it as a "failed sync" in the local sync history?
There was a problem hiding this comment.
Thanks for reviewing. I think so as well.
I think having a history array and fetching metadata on plugin load could work to store local sync failures. But any failed syncs added locally wouldn't show after plugin reload. Regardless, I do need some way to access the history in historyView.ts so storing a public array in main.ts might help.
There was a problem hiding this comment.
Yeah can store this in the plugin settings for now which is persisted. I think this is worth doing - there is also a local DB which I haven't explored much, could be a better place for persistence.
| undefined, | ||
| undefined, | ||
| [], | ||
| false, |
There was a problem hiding this comment.
Wonder if this should be true; having first sync be failed doesn't make sense to me, might add confusion after people reset metadata. Definitely a nitpick though and we can see the experience later & decide
There was a problem hiding this comment.
As in making the metadata deletion add to the sync history?
There was a problem hiding this comment.
Ah sorry, I see now the parameter is the deletion history - does false make sense as a value here vs undefined? definitely a nitpick, I was thinking it would log the sync as failed but I didn't finish tracing the code.
There was a problem hiding this comment.
All good, I'll make it undefined as I just rushed it a bit to see if I could get it working.
I'll also need to add something for the fails.
:)
|
Thanks for the PR and no problem! Added a couple comments, will keep an eye out for updates :) |
|
Thanks by the way! |
2 participants
To track changes to the sync history feature #43. This is in progress still.
Apologies for the duplicate pull request, I accidentally messed the other one up. (I'm still fairly new to Github)