Use distribution platform as supplier instead of package author#159
Merged
vpetersson merged 6 commits intomasterfrom Jan 31, 2026
Merged
Use distribution platform as supplier instead of package author#159vpetersson merged 6 commits intomasterfrom
vpetersson merged 6 commits intomasterfrom
Conversation
This refactors the enrichment module to set the supplier field to the distribution platform (PyPI, npm, crates.io, etc.) rather than the package author/maintainer. This better reflects NTIA semantics where "supplier" means the entity distributing the software. Changes: - Add PURL_TYPE_TO_SUPPLIER mapping in purl.py with 17 platform entries - Add get_supplier_for_purl() helper for unified supplier resolution - Update all enrichment sources to use centralized mapping: - pypi.py: "Python Package Index (PyPI)" - cratesio.py: "crates.io" - pubdev.py: "pub.dev" - conan.py: "Conan Center" - depsdev.py: Uses mapping based on PURL type - ecosystems.py: Uses mapping based on PURL type - Author info preserved in maintainer_name field (maps to SPDX originator) - Update tests to reflect new supplier behavior Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update test assertions to expect distribution platform as supplier: - test_pypi_author_email_without_author: expects "Python Package Index (PyPI)" - test_ecosystems_uses_platform_as_supplier: renamed from test_ecosystems_does_not_use_platform_as_supplier Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Tests that mock the sbomify API were being affected by the local sbomify.json file loaded by the JsonConfigProvider. Add patches to disable the JsonConfigProvider in these tests to ensure proper isolation. Affected tests: - test_augmentation_module.py: 6 tests - test_container_sbom_ntia_compliance.py: 1 test - test_schema_compliance.py: 2 tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
CycloneDX components now have both publisher and supplier fields: - publisher = package author/maintainer (e.g., "Django Software Foundation") - supplier = distribution platform (e.g., "Python Package Index (PyPI)") This addresses sbomqs comp_with_supplier compliance requirement. Changes: - Import OrganizationalEntity for CycloneDX supplier field - Set component.supplier to distribution platform from NormalizedMetadata - For OS packages (deb/rpm/apk), set maintainer_name = supplier so publisher shows the distribution name (e.g., "Debian Project") - Update tests for correct publisher/supplier expectations Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the enrichment module to set the supplier field to the
distribution platform (PyPI, npm, crates.io, etc.) rather than the
package author/maintainer. This better reflects NTIA semantics where
"supplier" means the entity distributing the software.
Changes: