Add drop-in PWA install component with custom trigger and iOS fallback#48
Open
sbsoftware-agent wants to merge 6 commits intoreleases/v0.31.0from
Open
Add drop-in PWA install component with custom trigger and iOS fallback#48sbsoftware-agent wants to merge 6 commits intoreleases/v0.31.0from
sbsoftware-agent wants to merge 6 commits intoreleases/v0.31.0from
Conversation
… Safari fallback panel
sbsoftware
reviewed
Feb 28, 2026
Owner
sbsoftware
left a comment
There was a problem hiding this comment.
Please use the js.cr DSL as much as possible, and only fall back to _literal_js for those instructions that aren't supported.
Also use the css.cr DSL with css_classes instead of custom attributes.
Collaborator
Author
|
Implemented in commit Changes made:
Verification:
Both passed. |
sbsoftware
reviewed
Feb 28, 2026
sbsoftware
reviewed
Feb 28, 2026
sbsoftware
reviewed
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a pluggable
Crumble::PwaInstallComponentthat works by calling#to_htmlfrom a consuming layout and requires no extra integration.Changes
src/pwa_install_component.cr:ToHtmlmarkup for a fixed-bottom mobile install CTA and iOS fallback instruction panel.JS::Codebehavior fragment that:beforeinstallpromptand defers native prompting,prompt()only from the custom button,src/crumble.crto require the new component.spec/pwa_install_component_spec.crcovering:#to_html,Verification
CRYSTAL_CACHE_DIR=/tmp/crystal-cache-cr crystal spec