Skip to content

Conversation

@haoqin
Copy link

@haoqin haoqin commented Feb 5, 2021

The purpose of the PR is to make it easier for sbt projects to use aspectj 1.9.x that is compatible with Java 11. Tested it by publishing it to local repo using sbt publishLocal. Environment: macOS Big Sur version 11.2 using openjdk 11.0.9.1, Scala 2.12.12, and sbt 1.4.6.

@kriegaex
Copy link

kriegaex commented May 7, 2021

Your description is imprecise. AspectJ 1.9.x supports different Java versions, depending on what "x" is, starting with 1.9.0 which supports Java 9. Version 1.9.6 supports Java 14, not just 11. FYI, the upcoming version 1.9.7 is going to support Java 16.

I think the update should be upgraded ASAP, otherwise I will have to answer more of questions like those on StackOverflow - I am also describing a workaround there:
https://stackoverflow.com/a/67427841/1082681

So thank you very much for the PR, it is valuable. 🙂 But the project seems to be dead or at least has been inactive for the past 3 years. I am an AspectJ expert, but never used Scala before. Is there anyone out there who could fork and maintain this plugin, or is there a better alternative for Scala users nowadays? I would like to know, because I answer questions about AspectJ regularly on StackOverflow.

@kriegaex kriegaex mentioned this pull request May 7, 2021
@kriegaex
Copy link

kriegaex commented Dec 1, 2021

Actually, the PR was outdated already, because the merge took so long. In June 2021, AspectJ 1.9.7 was released, supporting Java 16. The 3rd release candidate of 1.9.7 (1.9.7.RC3) with Java 17 support is also out, probably it is going to be mostly identical to the final release which only has not happened yet because my co-maintainer with release rights is busy.

See Maven Central.

@haoqin
Copy link
Author

haoqin commented Dec 11, 2021

Actually, the PR was outdated already, because the merge took so long. In June 2021, AspectJ 1.9.7 was released, supporting Java 16. The 3rd release candidate of 1.9.7 (1.9.7.RC3) with Java 17 support is also out, probably it is going to be mostly identical to the final release which only has not happened yet because my co-maintainer with release rights is busy.

See Maven Central.

@kriegaex The PR was done because the sbt-aspectj plugin was so useful that a group of developers wanted it to support the aspectj and scala versions they needed for their ongoing projects. The PR was done in case someone else might also have a similar need. We totally understand the maintainers have busy schedules and appreciate their contributions to the communities. If we have access to the group id, com.lightbend.sbt , we will be more than happy to publish our fork to a public maven repository under the lightbend group id. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants