Skip to content

Remove field RewriteRule.name #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Remove field RewriteRule.name #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ lazy val xml = crossProject(JSPlatform, JVMPlatform)
scalacOptions ++= "-deprecation:false -feature -Xlint:-stars-align,-nullary-unit,_".split("\\s+").to[Seq],
scalacOptions in Test += "-Xxml:coalescing",

mimaBinaryIssueFilters ++= {
import com.typesafe.tools.mima.core._
import com.typesafe.tools.mima.core.ProblemFilters._
Seq(
exclude[DirectMissingMethodProblem]("scala.xml.transform.RewriteRule.name")
)
},
mimaPreviousVersion := {
if (System.getenv("SCALAJS_VERSION") == "1.0.0-M6") None // No such release yet
else Some("1.1.1")
Expand Down
2 changes: 0 additions & 2 deletions shared/src/main/scala/scala/xml/transform/RewriteRule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ import scala.collection.Seq
* @author Burak Emir
*/
abstract class RewriteRule extends BasicTransformer {
/** a name for this rewrite rule */
val name = this.toString()
override def transform(ns: Seq[Node]): Seq[Node] = super.transform(ns)
override def transform(n: Node): Seq[Node] = n
}
Expand Down