Prohibit named tuple keys called 'apply' #24188
Open
+24
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
road21
reviewed
Oct 15, 2025
| untpd.Literal(Constant(nameIdx))), | ||
| pt) | ||
| if selName == nme.apply then | ||
| EmptyTree |
There was a problem hiding this comment.
What is the behavior of the following code now:
val boo: NamedTuple.NamedTuple[("_2", "apply"), (Int, Int)] = (1, 2)
println(boo.apply)I mean, that's too easy to bypass restrictions on named tuple field names. What error will be in this case?
There was a problem hiding this comment.
The validation doesn't apply to non-standard construction of named tuples (#23360). The compiler team decided that validation should only be applied to named tuples created with the spec (k:V) syntax. Either way of course it should not crash the compiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24021