-
Notifications
You must be signed in to change notification settings - Fork 5
Fix gRPC dependency issue #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a gRPC dependency conflict issue by excluding the AlloyDB JDBC connector dependency across multiple build profiles in the ScalarDB Cluster project.
- Excludes
com.google.cloud/alloydb-jdbc-connector
from dependency declarations to resolveNoClassDefFoundError: io/grpc/internal/NoopSslSession
- Updates exclusion lists across three build profiles (default, cassandra, and cluster)
- Updates comment to reflect both netty and gRPC dependency issues
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary of ChangesHello @brfrn169, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to resolve a "java.lang.NoClassDefFoundError" that has been observed in ScalarDB Cluster tests. The error is caused by a gRPC dependency conflict, specifically introduced by the "com.google.cloud/alloydb-jdbc-connector" dependency. The solution involves updating the "project.clj" configuration to exclude the problematic AlloyDB dependency, thereby eliminating the conflict and restoring stability to the cluster tests. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Description
We’ve recently been encountering the following errors in the ScalarDB Cluster tests:
It appears that this issue is caused by the AlloyDB dependency recently added to ScalarDB Core in scalar-labs/scalardb#3029. The AlloyDB dependency introduces a conflicting gRPC dependency, which leads to the
NoClassDefFoundError
.To resolve this issue, this PR excludes the AlloyDB dependency.
Related issues and/or PRs
N/A
Changes made
Checklist
Additional notes (optional)
N/A