Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -133,29 +133,31 @@ public class ImportCommandOptions {
@CommandLine.Option(
names = {"--data-chunk-size", "-dcs"},
paramLabel = "<DATA_CHUNK_SIZE>",
description = "Maximum number of records to be included in a single data chunk",
description =
"Maximum number of records to be included in a single data chunk (default: 500)",
Comment on lines +136 to +137
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

As detailed in the general feedback, manually adding the default value here is not ideal. It can lead to inconsistencies and maintenance issues. I recommend reverting this change in favor of enabling picocli's automatic default value display feature, which will handle this consistently for all options.

      description = "Maximum number of records to be included in a single data chunk",

defaultValue = "500")
protected int dataChunkSize;

@CommandLine.Option(
names = {"--transaction-size", "-ts"},
paramLabel = "<TRANSACTION_SIZE>",
description =
"Maximum number of put operations that are grouped together into one ScalarDB distributed transaction, only supported in ScalarDB transaction mode",
"Maximum number of put operations that are grouped together into one ScalarDB distributed transaction, only supported in ScalarDB transaction mode (default: 100)",
defaultValue = "100")
protected int transactionSize;

@CommandLine.Option(
names = {"--split-log-mode", "-slm"},
paramLabel = "<SPLIT_LOG_MODE>",
description = "Split log file into multiple files based on data chunks",
description = "Split log file into multiple files based on data chunks (default: false)",
defaultValue = "false")
protected boolean splitLogMode;

@CommandLine.Option(
names = {"--data-chunk-queue-size", "-qs"},
paramLabel = "<DATA_CHUNK_QUEUE_SIZE>",
description = "Maximum number of data chunks that can be kept at a time for processing",
description =
"Maximum number of data chunks that can be kept at a time for processing (default: 256)",
defaultValue = "256")
protected int dataChunkQueueSize;
}