Skip to content

Conversation

@feeblefakie
Copy link
Contributor

This is an automated request for a manual backport of the following:

  1. Resolve any conflicts that occur during the cherry-picking process.
git fetch origin &&
git checkout 3-pull-3071 &&
git cherry-pick --no-rerere-autoupdate -m1 97a83875cbba8ba24845793ca169754ad9f08d2c
  1. Push the changes.
  2. Merge this PR after all checks have passed.

Thank you!

@KodaiD KodaiD marked this pull request as ready for review October 21, 2025 07:58
@KodaiD
Copy link
Contributor

KodaiD commented Oct 21, 2025

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request backports a fix to prevent the metadata table from being dropped when renaming a table in a JDBC-based storage. The core change in JdbcAdmin.java introduces a flag to control the deletion of the metadata table, which is a clean and effective solution. The new integration tests in DistributedStorageAdminIntegrationTestBase and DistributedTransactionAdminIntegrationTestBase correctly cover the scenario that caused the original bug. The corresponding updates to unit tests and disabling of the new test for non-JDBC storages are also appropriate. I have one suggestion to improve the error handling to make it more robust and consistent with the rest of the codebase.

@brfrn169 brfrn169 merged commit 200f28b into 3 Oct 21, 2025
115 of 116 checks passed
@brfrn169 brfrn169 deleted the 3-pull-3071 branch October 21, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants