Skip to content

add a check to see if magnifying icon has already been added to icons…#162

Open
ianardavis wants to merge 1 commit intoscaleflex:masterfrom
ianardavis:fix-double-magnifying-icon
Open

add a check to see if magnifying icon has already been added to icons…#162
ianardavis wants to merge 1 commit intoscaleflex:masterfrom
ianardavis:fix-double-magnifying-icon

Conversation

@ianardavis
Copy link
Copy Markdown

… container

@ianardavis ianardavis closed this Apr 24, 2024
@ianardavis
Copy link
Copy Markdown
Author

Experienced issue when using plugin:

using not init on load
"<script>window.CI360 = { notInitOnLoad: true }</script>" in html.

add "images360.setAttribute( 'data-amount-x', imageList.length );" in JS file

initialising and adding hotspots
window.CI360.init();
window.CI360.addHotspots( 'images360', HOTSPOTS_CONFIG );

No errors occur in window, but two magnifying icons are present. this PR adds a check in the addMagnifying function to check there is not already an icon present before adding a new one.

@ianardavis ianardavis reopened this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant