Add CRR E2E tests #2272
Add CRR E2E tests #2272
Conversation
Hello kerkesni,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Kerkesni
force-pushed
the
improvement/ZENKO-5069
branch
5 times, most recently
from
3e97b38 to
0c3d12d
Compare
| }, | ||
| ), | ||
| string_data=credentials, | ||
| string_data={ |
There was a problem hiding this comment.
these secret are only used to store the creds from the "config" python script to the "test runner" script:
- may be read directly by the test
- or better yet, may be setup directly in the tests themself
@williamlardier is also working on refactoring and simplifying setup, please check with him best way to make the changes in some way that will be least complicated to merge.
There was a problem hiding this comment.
The accounts created here are used for creating the CRR users, so they need to be setup before the tests and before we create the CRR locations
There was a problem hiding this comment.
It's fine to do it here, I will migrate this too. I think we have no other choice than this approach for now
|
|
||
| user = iam_client.create_user(UserName="crr-user") | ||
| credentials = iam_client.create_access_key(UserName="crr-user") | ||
|
|
There was a problem hiding this comment.
could be done directly in tests, we have the API there as well?
There was a problem hiding this comment.
These are needed before the CRR locations are created, i want to avoid creating a location in the tests for stability purposes.
| next, | ||
| ), | ||
| ], done)); | ||
|
|
There was a problem hiding this comment.
missing test cases for "null version" object (created before versioning is enabled) : i..e writing version on top of it...
There was a problem hiding this comment.
This is an edge case that's known to not work, we have an open ticket about it CLDSRV-632
| "test_gcp_crr": "mocha --tags ${MOCHA_TAGS} --exit -t 10000 --reporter mocha-multi-reporters --reporter-options configFile=config.json backbeat/tests/crr/gcpBackend.js", | ||
| "test_one_to_many": "mocha --tags ${MOCHA_TAGS} --exit -t 10000 --reporter mocha-multi-reporters --reporter-options configFile=config.json backbeat/tests/crr/oneToMany.js", | ||
| "test_crr": "npm-run-all test_aws_crr test_azure_crr test_gcp_crr test_one_to_many", | ||
| "test_crr": "mocha --tags ${MOCHA_TAGS} --exit -t 10000 --reporter mocha-multi-reporters --reporter-options configFile=config.json backbeat/tests/crr/crr.js", |
There was a problem hiding this comment.
what about the earlier tests: test_aws_crr test_azure_crr test_gcp_crr test_one_to_many
shoud we not run them as well?
There was a problem hiding this comment.
Those tests were never executed, if i remember correctly i think you had a ticket to investigate why they fail a while ago but we never enabled them
putBucketReplicationMultipleBackend() can be used for any type of replication not just multiple backend Issue: ZENKO-5069
Kerkesni
force-pushed
the
improvement/ZENKO-5069
branch
from
0c3d12d to
65e3f71
Compare
Kerkesni
force-pushed
the
improvement/ZENKO-5069
branch
from
c220b2b to
e88c0d3
Compare
Issue: ZENKO-5069