Skip to content

Minor improvements and speedups in deps.sh#112

Open
Kuree wants to merge 459 commits intoscanner-research:masterfrom
Kuree:master
Open

Minor improvements and speedups in deps.sh#112
Kuree wants to merge 459 commits intoscanner-research:masterfrom
Kuree:master

Conversation

@Kuree
Copy link

@Kuree Kuree commented Dec 20, 2017

  1. add library check before installation;
  2. configure Boost.Build to only compile necessary libraries;
  3. clone with --depth 1 to reduce downloading time (ffmpeg's git server return error with depth, switch to the official Github mirror.)

willcrichton and others added 30 commits May 17, 2017 20:03
@willcrichton
Added GPU JPEG decode
0129e82
@willcrichton
Fixed the build
7df24b2
@willcrichton
Fixed nextPacket failure in GPU JPEG decoder
3bc7085
@fpoms
Fix stenciling for large stencils (+ add support for batching)
4cc714a
@fpoms
Update face detect example to take a path argument
58d9ed1
@willcrichton
Improved hyperlapse performance
c6bfb1f
@willcrichton
Fixed swscale link
5b3b7c6
@fpoms
Fix encoded video memory leak
6c629f0
@fpoms
Fix race condition in decoder automata
7bfb564
@fpoms
Don't delete data before using it :)
f4539cb
@willcrichton
Fixed swscale linkg
f688fbd
@willcrichton
More checks in memcpy
6360c09
@willcrichton
Add CPU memcpy
0e9a087
@willcrichton
Fixed cvc build error
958843a
@willcrichton
Fixed leak in encoder
ae5d3af
@willcrichton
Restored encode profiler
9d2267f
@fpoms
Fix bug with pre-evaluate worker not producing warmup rows
1de2a84
@fpoms
Should insert frame instead of element
7db96e8
@fpoms
Fix bug in kernel grouping
f80a831
@fpoms
Fix bug where decoder was getting frame information relative to items
c09ebc7 
Decoder currently requires absolute frame and keyframe ids but the
system was providing relative frame ids
@fpoms
Fixed end of task scenarios involving batching not giving sub batches
6f30d65
@fpoms
Support batching on discard kernel
03d0d76
@fpoms
Accidental printfs
c86183b
@fpoms
Copy decoder race condition fix from master
65c1d71
@fpoms
Update config to take db_path arg, rename item_size to task_size
59c8360
@fpoms
Elide copy needed for stencil cache when stencil is just [0]
f7eb10f 
This copy was causing performance regressions on previous benchmarks
@fpoms
Update python tests for item_size -> task_size
d138fef
@fpoms
Fix bugs with stencil cache implementation
4be8a6e
@fpoms
Update GPU optical flow kernel for stencil interface
eec4e5a
@willcrichton
Added load sparisty threshold, factored out cpu/gpu image decoders
d090f6b
fpoms and others added 24 commits December 18, 2017 14:16
@fpoms
Export env variables in deps.sh, add missing resource files
3032266
@fpoms
Add cmake find for GRPC, add swscale to ffmpeg cmake
13f9adb
@fpoms
GRPC libraries were in wrong order
f687e6a
@fpoms
Typo
9588b79
@fpoms
Merge scanner-docker dockerfiles, update docker to work with deps.sh
eee2709
@fpoms
Update docker files to build properly
0caab05
@fpoms
Update travis build to new dockerfile location
d45a3cf
@fpoms
Dockerfile should be specified on build, not run cmd
69d1e61
@fpoms
Dependencies are already built in base image
a83e5df
@fpoms
Do not include openface op in dockerfile for now
169cdf5
@fpoms
Fix not finding halide dir
a76bc3a
@fpoms
Caffe should be installed by default
725288c
@fpoms
Fix TinyToml and Storehouse not being found
7ef520e
@fpoms
Typo
b699800
@willcrichton
Don't use root logger
d59f8d0
@willcrichton
Multicore boost build
b1e2045
@fpoms
Fix grpc not using proper include flags
d146aff
@fpoms
Typo
5c94963
@willcrichton
Fix Caffe build in deps.sh
48af7bd
@willcrichton
Fix grpc install
05888ac
@willcrichton
storehousepy -> storehouse
59a3797
@fpoms
Make docker build context the scanner root
584c7f2
@fpoms
Include nvcuvid in docker
1809a6f
@Kuree
deps.sh:
db5c988 
    1) add library check before installation;
    2) configure Boost.Build to only compile necessary libraries;
    3) clone with --depth 1 to reduce downloading time (ffmpeg's git server doesn't support depth, switch to official Github mirror.)
@fpoms
Copy link
Contributor

fpoms commented Dec 21, 2017

Looks good! Would you mind rebasing this onto current master?

@Kuree
Copy link
Author

Kuree commented Dec 21, 2017

It should be rebased already.

fpoms
fpoms requested changes Dec 21, 2017
View reviewed changes
deps.sh
echo "$lib is not installed. abort"
exit 1
fi
done
Copy link
Contributor

@fpoms fpoms Dec 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue with this check is that a user might have installed some of these dependencies without using the package manager. Having this hard failure here would cause an issue in that case. Perhaps change this to print a warning instead?

Copy link
Author

@Kuree Kuree Dec 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree. Maybe we can seperate the library check on dependency basis? For instance, we only check libjpeg-dev etc if the user wants to install OpenCV?

@willcrichton willcrichton force-pushed the master branch 2 times, most recently from 6822cde to 5d4d222 Compare April 19, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fpoms fpoms fpoms requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Kuree @fpoms @willcrichton @sdulloor @qianl15