Skip to content

Conversation

@agustingroh
Copy link
Contributor

What's Changed

Changed

  • Refactored service structure for better organization
  • Added status support to all cryptography response blocks
  • General code cleanup and improvements

@agustingroh agustingroh self-assigned this Oct 10, 2025
Copy link
Contributor

@scanoss-qg scanoss-qg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isasmendiagus isasmendiagus self-requested a review October 13, 2025 09:25
Copy link
Contributor

@isasmendiagus isasmendiagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test are not passing

@agustingroh
Copy link
Contributor Author

Test are not passing

Not until papi definition are not being deployed

@agustingroh agustingroh force-pushed the chore/enhance-status-responses branch from 506f6bc to cbfc338 Compare October 13, 2025 14:07
@agustingroh agustingroh force-pushed the chore/enhance-status-responses branch from 046f716 to efa6f4d Compare October 13, 2025 14:24
@agustingroh agustingroh requested a review from eeisegn October 13, 2025 14:44
Copy link
Contributor

@scanoss-qg scanoss-qg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I saw some empty lines. Hopefully linter won't scream

Copy link
Contributor

@eeisegn eeisegn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create/update the docs.go files and increase the code coverage of handlers package

@agustingroh agustingroh force-pushed the chore/enhance-status-responses branch from ab62980 to 3b6dc53 Compare October 13, 2025 18:54
@agustingroh agustingroh requested a review from eeisegn October 13, 2025 18:54
@agustingroh agustingroh dismissed isasmendiagus’s stale review October 13, 2025 20:53

All changes were done

@agustingroh agustingroh merged commit bb86253 into main Oct 13, 2025
2 checks passed
@agustingroh agustingroh deleted the chore/enhance-status-responses branch October 13, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants