Skip to content

Conversation

EricccTaiwan
Copy link
Collaborator

Sync with the latest upstream updates and remove unused code.

Ref: https://github.com/jjyr/buddy-alloc

Sync with the latest upstream updates and remove unused code.

Ref: https://github.com/jjyr/buddy-alloc

Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
@EricccTaiwan EricccTaiwan force-pushed the rustland-core-alloc-update branch from 235eecc to a8ed490 Compare September 19, 2025 05:11
Copy link
Contributor

@arighi arighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... no, please. We shouldn't blindly sync with upstream, our use case is quite special and it may introduce subtle bugs. We should only apply clear fixes with a proper description of what they're fixing. And cleanups are also fine, but again, with a clear description of what they're cleaning up.

So, if we can split this PR in multiple commits each one describing the change that it's adding or the cleanup, that'd be fine.

Otherwise it might be problematic to bisect and identify potential issues.

@EricccTaiwan
Copy link
Collaborator Author

I see.

I noticed that some of the issues you mentioned earlier seem to have been fixed. I’ll take a closer look at those and send separate commits accordingly.

@arighi
Copy link
Contributor

arighi commented Sep 19, 2025

I see.

I noticed that some of the issues you mentioned earlier seem to have been fixed. I’ll take a closer look at those and send separate commits accordingly.

Maybe check also stress-ng --race-sched 0 and stress-ng -c 0 while running https://webglsamples.org/aquarium/aquarium.html and see if the changes are affecting the fps. This is a good test to quickly detect performance regressions. Thanks!

@EricccTaiwan EricccTaiwan marked this pull request as draft September 19, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants